#42111: Nation translation_domain "freeciv-core" Open Date: 2021-04-29 03:43 Last Update: 2021-11-21 09:00 URL for this Ticket: https://osdn.net//projects/freeciv/ticket/42111 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=42111 --------------------------------------------------------------------- Last Changes/Comment on this Ticket: 2021-11-21 09:00 Updated by: cazfi * Resolution Update from None to Accepted Comment: New version fixes civ1 ruleset --------------------------------------------------------------------- Ticket Status: Reporter: cazfi Owner: (None) Type: Patches Status: Open Priority: 5 - Medium MileStone: S3_1 d3f Component: Server Severity: 5 - Medium Resolution: Accepted --------------------------------------------------------------------- Ticket details: When translation domain "freeciv" was renamed as "freeciv-core", nation rulesets, or related code in ruleset.c, was not updated. By luck, it's not really broken, and thus I'm not targeting fix to S3_0 (that is already d3f). Though the nation ruleset files set the nonexistent domain "freeciv", that's also what ruleset.c checks for the default to be, and then does the right thing. For later branches we should change the domain name in nation ruleset files to match the actual domain name, i.e., "freeciv-core". As part of #43200, this has also been posted to http://forum.freeciv.org/f/viewtopic.php?f=14&t=92040 -- Ticket information of Freeciv project Freeciv Project is hosted on OSDN Project URL: https://osdn.net/projects/freeciv/ OSDN: https://osdn.net URL for this Ticket: https://osdn.net/projects/freeciv/ticket/42111 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=42111