#42969: Client: Make trade route drawing robust against unknown partner
Open Date: 2021-10-02 15:26
Last Update: 2021-10-02 15:41
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/42969
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=42969
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2021-10-02 15:41 Updated by: cazfi
* Resolution Update from None to Accepted
* Milestone Update from (None) to 3.0.0
Comment:
S2_6 is not affected, as there the iterator macro used contains NULL check.
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: (None)
Type: Patches
Status: Open
Priority: 5 - Medium
MileStone: 3.0.0
Component: Client common
Severity: 5 - Medium
Resolution: Accepted
---------------------------------------------------------------------
Ticket details:
Related to #42968
Currently player is expected to always know any trade partners of his/her own cities, but 1) it won't hurt for the client to be robust against the opposite case, and 2) that might not be true sometime in the future.
This ticket is about changing draw_trade_routes_for_city() not to crash when the trade partner from trade_partners_iterate() is NULL.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/42969
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=42969