#44140: Ruledit: Inconsistent initial state of same_name toggles Open Date: 2022-03-17 19:34 Last Update: 2022-04-16 04:10 URL for this Ticket: https://osdn.net//projects/freeciv/ticket/44140 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44140 --------------------------------------------------------------------- Last Changes/Comment on this Ticket: 2022-04-16 04:10 Updated by: cazfi * Status Update from Open to Closed * Resolution Update from Accepted to Fixed --------------------------------------------------------------------- Ticket Status: Reporter: cazfi Owner: cazfi Type: Patches Status: Closed Priority: 5 - Medium MileStone: 3.0.2 Component: Ruledit Severity: 5 - Medium Resolution: Fixed --------------------------------------------------------------------- Ticket details: Initially, when no item is selected (i.e. both rule_name and name are "None") same_name toggle is checked in tech tab, but not in other tabs. I think it should (as it should be the default). In the code, the difference between techs and at least terrains tab seems to be that techs call update_tech_info() in the end of the constructor, while terrains does not call update_terrain_info(). Those update_*_info() methods set same_name toggled in case of no-item-selected. There might be other functionality in update_*_info() that should be executed in the constructor. -- Ticket information of Freeciv project Freeciv Project is hosted on OSDN Project URL: https://osdn.net/projects/freeciv/ OSDN: https://osdn.net URL for this Ticket: https://osdn.net/projects/freeciv/ticket/44140 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44140