#43745: generate_packets.py minimum Python version Open Date: 2022-01-30 22:09 Last Update: 2022-02-02 16:21 URL for this Ticket: https://osdn.net//projects/freeciv/ticket/43745 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=43745 --------------------------------------------------------------------- Last Changes/Comment on this Ticket: 2022-02-02 16:21 Updated by: cazfi Comment: Reply To alienvalkyrie without python3, autogen.sh will fail Good reminder about autogen.sh. Whatever gets decided as the minimum python version, autogen.sh check should be updated to require. --------------------------------------------------------------------- Ticket Status: Reporter: alienvalkyrie Owner: (None) Type: Bugs Status: Open Priority: 5 - Medium MileStone: (None) Component: General Severity: 5 - Medium Resolution: None --------------------------------------------------------------------- Ticket details: The comment in common/generate_packets.py claims it's compatible with every Python version since 1.5, and says to keep it that way; in particular, not to replace string.join calls. The update to make the script Python-3-compatible did just that. Clearly, the script is not 1.5-compatible anymore (nor does it need to). Given the use of a python3 executable, our minimum supported version is in the Python 3 range – we should figure out / decide what specific version we want that to be, and update the comment accordingly. -- Ticket information of Freeciv project Freeciv Project is hosted on OSDN Project URL: https://osdn.net/projects/freeciv/ OSDN: https://osdn.net URL for this Ticket: https://osdn.net/projects/freeciv/ticket/43745 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=43745