#43996: Qt: Remove 'menu' from mr_menu class Open Date: 2022-03-01 12:00 Last Update: 2022-03-01 12:00 URL for this Ticket: https://osdn.net//projects/freeciv/ticket/43996 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=43996 --------------------------------------------------------------------- Last Changes/Comment on this Ticket: 2022-03-01 12:00 Updated by: cazfi * New Ticket "Qt: Remove 'menu' from mr_menu class" created --------------------------------------------------------------------- Ticket Status: Reporter: cazfi Owner: cazfi Type: Patches Status: Open [Owner assigned] Priority: 5 - Medium MileStone: 3.0.1 Component: Qt-client Severity: 5 - Medium Resolution: None --------------------------------------------------------------------- Ticket details: Step to refactor related code for the goal of debugging (by whatever means) #43944. 'menu' member of class mr_menu is used only by setup_menu() method, and there it's reused several times (to mean different things) -> it's not needed in mr_menu, and it has no clear meaning there. Remove it from the class, and have it only locally in setup_menus() -- Ticket information of Freeciv project Freeciv Project is hosted on OSDN Project URL: https://osdn.net/projects/freeciv/ OSDN: https://osdn.net URL for this Ticket: https://osdn.net/projects/freeciv/ticket/43996 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=43996