#43995: generate_packets.py get run on every build Open Date: 2022-03-01 09:49 Last Update: 2022-03-01 11:38 URL for this Ticket: https://osdn.net//projects/freeciv/ticket/43995 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=43995 --------------------------------------------------------------------- Last Changes/Comment on this Ticket: 2022-03-01 11:38 Updated by: alienvalkyrie Comment: One (quick and dirty) way to solve the potential problem for release tarballs would be to run the script with --force-overwrite once, to make sure the generated files are newer. For this, it might be sensible to make some of generate_packets.py's parameters more directly controllable through configure options. It might even be sensible to make force-overwrite the default, and only enable lazy-overwrite with certain configure options. Another (more general) solution to prevent re-running the script every time, even with lazy-overwrite (which could become a problem anyway if the script ever starts taking longer to run), would be to take the intermediate dummy packets_generate file (which is currently temporarily created to guard against problems in parallel builds) and make it a permanent resident to use as a timestamp for when generate_packets.py was last run – it would always get refreshed by the build system, even when the actual output files didn't change. Also, for the potential release tarball problem – maybe there could be a --without-python configure option (that must, of course, check that all generated files are already present) to generally sidestep that problem, rather than just trusting that the build system won't be running any Python scripts? --------------------------------------------------------------------- Ticket Status: Reporter: cazfi Owner: (None) Type: Bugs Status: Open Priority: 5 - Medium MileStone: 3.2.0 Component: Bootstrap Severity: 5 - Medium Resolution: None --------------------------------------------------------------------- Ticket details: Current master: even when I run 'make' twice in a row, without changing absolutely anything, the output shows that generate_packets.py gets run. Don't understand why. I've checked timestamps of both generate_packets.py and packets.def, and neither has any weird in-future timestamp. This is probably mostly harmless in a development branch, but if the same happens (haven't tested) in a build from a release tarball, that breaks a build without python. -- Ticket information of Freeciv project Freeciv Project is hosted on OSDN Project URL: https://osdn.net/projects/freeciv/ OSDN: https://osdn.net URL for this Ticket: https://osdn.net/projects/freeciv/ticket/43995 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=43995