#44484: Qt: option_dialog::add_option() references through NULL widget pointer
Open Date: 2022-04-29 07:58
Last Update: 2022-05-09 18:51
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/44484
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44484
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-05-09 18:51 Updated by: cazfi
* Status Update from Open to Closed
* Resolution Update from Accepted to Fixed
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: cazfi
Type: Bugs
Status: Closed
Priority: 5 - Medium
MileStone: 3.0.2
Component: Qt-client
Severity: 5 - Medium
Resolution: Fixed
---------------------------------------------------------------------
Ticket details:
Originally from clang static analyzer report.
option_dialog::add_option() initialized 'widget' as NULL. In most cases it then gets set to a real value, but not always. Part of the following code is within "if (widget != NULL)", but even outside that block there's some references through 'widget'.
I've not tested it yet, but this seems something that can cause a client crash.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/44484
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44484