S3_0 alien Grassland has inconsistent mining_result & mining_time

• Informador: cazfi
• Propietario: cazfi
• Tipo: Bugs
• Estado: Cerrado
• Componente: General
• Hito: 2.6.5 (cerrado)
• Prioridad: 5 - Medium
• Gravedad: 5 - Medium
• Resolución: Fixed
• Fichero: 2

Details

S3_1 CI ruleup test for alien is failing, because S3_0 alien to upgrade from has mining_result = "no", but mining_time = 10 for Grassland. S3_1 now has a sanity check against that.

That's not hard error in S3_0 (the mining_time gets ignored when mining_result is "no"), and S3_0 is in semi-freeze before beta2 release. Still, maybe we consider fixing CI important enough to push in the fix now?

Ticket History (3/7 Histories)

2021-05-10 21:36 Updated by: cazfi

• New Ticket "S3_0 alien Grassland has inconsistent mining_result & mining_time" created

2021-05-10 21:45 Updated by: cazfi

• File 0024-Alien-Make-irrigation-plant_time-consistent-with-_re.patch (File ID: 6749) is attached

2021-05-10 21:45 Updated by: cazfi

• Resolución Update from Ninguno to Accepted
• Hito Update from (Ninguno) to 2.6.5 (cerrado)

2021-05-10 21:48 Updated by: cazfi

Comentario

Maybe S3_1 should convert _time to zero in this kind of situations?

2021-05-10 22:04 Updated by: cazfi

• File 0034-Ruleup-Set-cultivate-plant_time-to-zero-when-activit.patch (File ID: 6750) is attached

2021-05-10 22:06 Updated by: cazfi

• Componente Update from Rulesets to General

Comentario

Now one patch for S3_0/S2_6, to fix the ruleset, and another for S3_1, to convert from inconsistent S3_0 ruleset, attached. Going to push S3_1 one immediately as a CI fix. S3_0/S2_6 patch will wait until after 3.0.0-beta2 is out.

2021-05-16 11:52 Updated by: cazfi

• Estado Update from Open to Cerrado
• Propietario Update from (Ninguno) to cazfi
• Resolución Update from Accepted to Fixed