Fix build failure on older OS X versions

• Informador: (Anónimo)
• Propietario: cazfi
• Tipo: Patches
• Estado: Cerrado
• Componente: General
• Hito: 2.6.5 (cerrado)
• Prioridad: 5 - Medium
• Gravedad: 5 - Medium
• Resolución: Fixed
• Fichero: Ninguno

Details

Build can fail due to including sys/random.h when it's not needed. Example failure: https://build.macports.org/builders/ports-10.11_x86_64-builder/builds/139520/steps/install-port/logs/stdio

Pull request with proposed fix: https://github.com/freeciv/freeciv/pull/29

Ticket History (3/5 Histories)

2021-05-31 18:04 Updated by: None

• New Ticket "Fix build failure on older OS X versions" created

2021-05-31 18:46 Updated by: cazfi

Comentario

Should not check boolean value of those macros, but if they both are defined (at all): #if defined() && defined()

2021-05-31 18:47 Updated by: cazfi

• Hito Update from (Ninguno) to 2.6.5 (cerrado)

2021-06-02 10:35 Updated by: cazfi

• Resolución Update from Ninguno to Accepted

Comentario

Reply To cazfi

Should not check boolean value of those macros, but if they both are defined (at all): #if defined() && defined()

There's now a new version of the pull request with this fixed. It applies cleanly to all branches.

2021-06-04 10:08 Updated by: cazfi

• Estado Update from Open to Cerrado
• Propietario Update from (Ninguno) to cazfi
• Resolución Update from Accepted to Fixed