Incidencia #42647

Qt Client crashes when using "Investigate city" diplomat/spy option AND when using "Contribute to Wonder" caravan option.

Abrir Fecha: 2021-07-19 22:33 Última actualización: 2022-06-11 21:50

Informador:
(Anónimo)
Propietario:
(Ninguno)
Tipo:
Estado:
Open
Componente:
Hito:
Prioridad:
5 - Medium
Gravedad:
5 - Medium
Resolución:
Ninguno
Fichero:
Ninguno

Details

Noticed this last week when trying to do both actions in one game.

How to reproduce Diplomat/spy bug: 1. Play any game on the Freeciv Qt Client. 2. Build or start with a diplomat. 3. Send diplomat to any AI city and when the dialog box comes up, select the "Investigate City" option. 4. Client will attempt to open enemy city up, and then immediately crash.

How to reproduce Caravan bug: 1. Play any game on the Freeciv Qt Client. 2. Build a caravan. 3. Build a wonder in any city. 4. Move the caravan to the wonder building city and when the dialog box comes up, select the "Contribute to production" option. 5. Game will immediately crash afterwards.

I have tested both functions in the GTK+ client and they work on there completely fine, it seems to be just the Qt client that has this problem. I cannot confirm if the SDL client has the same option. This problem also exists in the new beta Qt client, as I have tested it there also.

I ran the game on Windows 10, latest update as of 19-07-2021.

Ticket History (3/15 Histories)

2021-07-19 22:33 Updated by: None
  • New Ticket "Qt Client crashes when using "Investigate city" diplomat/spy option AND when using "Contribute to Wonder" caravan option." created
2021-09-01 14:50 Updated by: cazfi
Comentario

Do you have a savegame from which to (reliably) reproduce this? My attempt to reproduce failed - there might be something specific needed in the target city for the crash to occur.

2021-09-06 10:22 Updated by: None
Comentario

Reply To cazfi

Do you have a savegame from which to (reliably) reproduce this? My attempt to reproduce failed - there might be something specific needed in the target city for the crash to occur.

All I did was download the latest qt client from the website. Just start as any civilization under the civ2civ3 rules. Use the diplomat you get to investigate the city of any civilization near you, and the client will crash everytime.

I'm on a Windows 10 if that counts.

2021-12-10 08:07 Updated by: cazfi
2022-02-03 13:05 Updated by: cazfi
2022-02-20 12:20 Updated by: ddeanbrown
Comentario

Tested with 3.0.0, not on Windows, and Spy "Investigate City"worked OK, and Caravan "Help Build Wonder" worked OK.

2022-04-13 20:17 Updated by: cazfi
2022-04-19 10:24 Updated by: cazfi
Comentario

I heard that someone had also "Establish Embassy" crashing on Windows 10. Qt-client, freeciv-3.0.0. Could be related to Russian locale.

2022-04-19 11:07 Updated by: cazfi
Comentario

Though nobody has seen this in linux, I wonder if valgrind would detect anything if one would run Qt-client in it with Russian locale.

2022-06-01 23:40 Updated by: cazfi
Comentario

Still no progress with this. The valgrind runs I've done have found one problem specific to a "long translation" (Russian translation overflowing the buffer), but that was completely unrelated to to any diplomat actions.

Can you attach your client settings file (freeciv-client-rc-3.0) in case this only happens with specific settings?

2022-06-02 04:47 Updated by: cazfi
Comentario

Reply To (Anonymous)

Null actor_unit? https://github.com/freeciv/freeciv/blob/master/client/packhand.c#L5026-L5032

Thanks. Sounds feasible at least in that actions mentioned do consume their actor. In any case it's a bug that the client trusts unit id it has received from the server to map to an unit it knows.

As this is a crash that people are known to actually encounter, would very much want it fixed in 3.0.2 release. Does anyone have a moment to work on this?

2022-06-05 14:38 Updated by: cazfi
Comentario

Reply To cazfi

In any case it's a bug that the client trusts unit id it has received from the server to map to an unit it knows.

Split to -> #44757

On closer inspection it seems unlikely to be the cause of the issue of this ticket, so I'd rather keep this ticket open for now.

2022-06-06 05:51 Updated by: cazfi
Comentario

Reply To (Anonymous)

I'm on a Windows 10 if that counts.

I now tested on Windows 11, with a current snapshot build of freeciv-3.0, and saw no such problems. That was with the 64bit (win64) build.

2022-06-11 21:50 Updated by: cazfi

Attachment File List

No attachments

Editar

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Entrar