Incidencia #42704

civ2civ3: patches compatible with 2.6

Abrir Fecha: 2021-08-11 05:37 Última actualización: 2021-09-27 05:55

Informador:
Propietario:
(Ninguno)
Tipo:
Estado:
Open
Componente:
Hito:
(Ninguno)
Prioridad:
5 - Medium
Gravedad:
5 - Medium
Resolución:
Ninguno
Fichero:
Ninguno

Details

This ticket will join in one place the patches for civ2civ3 made by me that are compatible with v2.6, and I expect to be included in future v3.1 I'll make the patch for S2_6 only if it is a bug fix (none planned for now). And I'll make the patch for S3_0 if I think most people would consider it an improvement and there is low risk of breaking anything.

Now that I'm on vacation, I hope I can finally finish the patches I had planned.

Ticket History (3/8 Histories)

2021-08-11 05:37 Updated by: bard
  • New Ticket "civ2civ3: patches compatible with 2.6" created
2021-08-14 08:52 Updated by: bard
Comentario

I created this ticket expecting that I'd be able to add references to other tickets, but I don't see how. I guess I have to do it manually:

Ticket #42708 civ2civ3: adjust script that adds labels to the map

Ticket #42709 civ2civ3: infantry units can build fortresses

Ticket #42712 civ2civ3: culture has effects

... more in the way

(Edited, 2021-08-15 12:36 Updated by: bard)
2021-08-15 10:34 Updated by: bard
Comentario

The patches I list here were made for v2.5 or v2.6 long time ago, and most of them have been in my "earth" version of the ruleset for years. Although I never received any feedback so it is as if they were only tested by me :)

I do not plan to make any patch that requires new gfx, at least for now, and the rest is very similar in both rulesets (official civ2civ3 and my custom earth version), so don't be afraid, I'm not planning to submit that many changes.

I have started by the patches that require more changes, and that could affect more the gameplay, in order to allow some debate. But the rest of my planned patches will have less and less effect on gameplay, and my final patches will just change some implementation/coding to try to simplify it, or fix some typo errors.

I think this ticket would be a good place to talk about the development of civ2civ3, in case someone has some general suggestions or guidelines.

2021-09-05 18:36 Updated by: bard
Comentario

Some question about style:

If I create a new helptext, which format is preferred: 1) space at the end of the line

helptext             = _("\
Glaciers are found only in the most northerly or southerly reaches \
of the world. They are very cold, and hence difficult to work with.\
")
2) or space at the start of the new line:
helptext             = _("\
Glaciers are found only in the most northerly or southerly reaches\
 of the world. They are very cold, and hence difficult to work with.\
")

When they are mixed in the same file, they use to appear errors where there are 2 spaces or none between words. I rather use always the same, no matter which one. Which one is recommend?

I have a similar question about the use of tabs or spaces in the middle of a line. The file effects.ruleset almost always use spaces, but there are some remaining tabs, and I recently (civ2civ3 v2.6) introduced by mistake some more tabs in all the building effects related to culture (marked with dots in the following example):

[effect_cathedral_culture]
type....= "History"
value...= 3
reqs....=
    { "type", "name", "range"
      "Building", "Cathedral", "City"
    }
I was going to make a patch to change them from tabs to spaces again. Would it be ok? Should I change all tabs to spaces in the effects.ruleset file (including those related to diplomacy and agent actions), or only the ones introduced by me in civ2civ3 (so the diplomacy section keeps the same format in all rulesets)? Or I better keep all tabs/spaces unchanged?

2021-09-05 18:53 Updated by: cazfi
Comentario

Reply To bard

If I create a new helptext, which format is preferred: 1) space at the end of the line 2) or space at the start of the new line

There's no clear consensus about that, so I think either is acceptable at this time.

I recently (civ2civ3 v2.6) introduced by mistake some more tabs in all the building effects related to culture I was going to make a patch to change them from tabs to spaces again. Would it be ok? Should I change all tabs to spaces in the effects.ruleset file (including those related to diplomacy and agent actions), or only the ones introduced by me in civ2civ3 (so the diplomacy section keeps the same format in all rulesets)? Or I better keep all tabs/spaces unchanged?

Either change just those tabs to spaces (so that civ2civ3 effects.ruleset has equivalent format to other effects.rulesets) or change all tabs in all effects.rulesets. I don't think the middle-ground of changing all tabs in just civ2civ3 effects.ruleset would be a good idea.
2021-09-05 19:04 Updated by: bard
Comentario

Reply To cazfi

There's no clear consensus about that, so I think either is acceptable at this time.

Ok, I like to use 1) because the resultant text looks more similar to the actual text as shown in the UI. But I guess it is also more prone to errors of missing spaces.

Either change just those tabs to spaces (so that civ2civ3 effects.ruleset has equivalent format to other effects.rulesets) or change all tabs in all effects.rulesets. I don't think the middle-ground of changing all tabs in just civ2civ3 effects.ruleset would be a good idea.

Sounds reasonable. I'll change just the tabs introduced by me in civ2civ3.

2021-09-25 13:04 Updated by: cazfi
Comentario

Do you have any idea how to handle https://www.hostedredmine.com/issues/857352 ?

2021-09-27 05:55 Updated by: bard
Comentario

Thank you for pointing it. I had not checked hostedredmine since I started using osdn. This week I'll try to check it for other bugs related to civ2civ3, and I'll continue with the patches of this ticket.

Attachment File List

No attachments

Editar

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Entrar