Incidencia #42992

Inconsistent code about "Local" range "Good" reqs

Abrir Fecha: 2021-10-07 17:30 Última actualización: 2021-10-07 17:30

Informador:
Propietario:
(Ninguno)
Tipo:
Estado:
Open
Componente:
Hito:
(Ninguno)
Prioridad:
5 - Medium
Gravedad:
5 - Medium
Resolución:
Ninguno
Fichero:
Ninguno

Details

When looking #42944

Additional inconsistency is that is_goods_type_in_range() would accept "Local" range, if the ruleset loading would ever let it through. As currently implemented, it's identical to "City" range, but I guess the idea might have been that it should check if the local tile has a city with the good imported, i.e., there would be slight semantic difference between "Local" and "City" causing evaluation to be against different city in some cases.

As the ruleset loading time checks guard against ever getting Good requirement with "Local" range, resolving this issue is not urgent, end especially a solution where the functionality gets extended can only occur in later branches that are not yet d3f.

Ticket History (1/1 Histories)

2021-10-07 17:30 Updated by: cazfi
  • New Ticket "Inconsistent code about "Local" range "Good" reqs" created

Attachment File List

No attachments

Editar

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Entrar