only_real_fight_makes_veteran

• Informador: cazfi
• Propietario: cazfi
• Tipo: Patches
• Estado: Cerrado
• Componente: General
• Hito: S3_1 d3f (cerrado)
• Prioridad: 5 - Medium
• Gravedad: 5 - Medium
• Resolución: Fixed
• Fichero: 3

Details

In https://www.hostedredmine.com/issues/809590#note-7 bard says:

"However, I was missing a way to prevent promotions when the defending unit has defense 0 (or no way to damage the attacker)."

I think that natural way to do this is to introduce new "only_real_fight_makes_veteran" setting alongside the existing "only_killing_makes_veteran".

Ticket History (3/9 Histories)

2021-10-10 00:23 Updated by: cazfi

• New Ticket "only_real_fight_makes_veteran" created

2021-10-10 00:50 Updated by: cazfi

• File 0052-Add-only_real_fight_makes_veteran-ruleset-setting.patch (File ID: 7613) is attached

2021-10-10 00:50 Updated by: cazfi

• File 0037-Add-only_real_fight_makes_veteran-ruleset-setting.patch (File ID: 7614) is attached

2021-10-10 00:50 Updated by: cazfi

• Resolución Update from Ninguno to Accepted

2021-10-10 02:57 Updated by: bard

Comentario

I like it. Thank you. I'll try to test it.

2021-10-18 09:21 Updated by: cazfi

• Resolución Update from Accepted to Ninguno

Comentario

master version of rulesave.c should add the comment, but does not (comments.c part has been made, the only thing missing is call from rulesave.c)

2021-10-19 08:24 Updated by: cazfi

• File 0013-Add-only_real_fight_makes_veteran-ruleset-setting.patch (File ID: 7675) is attached

2021-10-19 08:25 Updated by: cazfi

• Resolución Update from Ninguno to Accepted

Comentario

New version for master, with proper saving of the ruleset comment in rulesave.

2021-10-30 17:37 Updated by: cazfi

• Estado Update from Open to Cerrado
• Propietario Update from (Ninguno) to cazfi
• Resolución Update from Accepted to Fixed