Rename "Firepower1" combat bonus as "MinimalFirepower"

• Informador: cazfi
• Propietario: cazfi
• Tipo: Patches
• Estado: Cerrado
• Componente: General
• Hito: S3_1 d3f (cerrado)
• Prioridad: 5 - Medium
• Gravedad: 5 - Medium
• Resolución: Fixed
• Fichero: 2

Details

As we're changing hardcoded firepower of '1' as used by various special cases to a ruleset defined values in #43041, name of combat bonus "FirePower1" is getting misleading. Rename it to "MinimalFirePower".

As part of #43200, this has also been posted to http://forum.freeciv.org/f/viewtopic.php?f=14&t=92036

Ticket History (3/9 Histories)

2021-10-19 13:17 Updated by: cazfi

• New Ticket "Rename "Firepower1" combat bonus as "MinimalFirepower"" created

2021-11-08 11:54 Updated by: cazfi

Comentario

Shorter "MinFirePower" would probably do, without being any more confusing than "MinimalFirePower" (when followed by a value that is *not* the "minimal" firepower but sort of boolean enabling the bonus)

2021-11-09 21:09 Updated by: cazfi

Comentario

Reply To cazfi

Shorter "MinFirePower" would probably do, without being any more confusing than "MinimalFirePower" (when followed by a value that is *not* the "minimal" firepower but sort of boolean enabling the bonus)

Maybe "LowFirepower" would be less confusing?

2021-11-13 16:47 Updated by: cazfi

• Details Updated

2021-11-13 16:49 Updated by: cazfi

• File 0025-Rename-Firepower1-combat-bonus-as-LowFirepower.patch (File ID: 7932) is attached

2021-11-13 16:49 Updated by: cazfi

• File 0018-Rename-Firepower1-combat-bonus-as-LowFirepower.patch (File ID: 7933) is attached

2021-11-13 16:49 Updated by: cazfi

• Resolución Update from Ninguno to Accepted

Comentario

Attached patches go for "LowFirepower"

2021-11-23 01:35 Updated by: cazfi

Comentario

When pushing this, also update S3_1 commit hash that master does CI ruleup tests from.

2021-11-25 17:51 Updated by: cazfi

• Estado Update from Open to Cerrado
• Propietario Update from (Ninguno) to cazfi
• Resolución Update from Accepted to Fixed