Rename "Firepower1" combat bonus as "MinimalFirepower"
Shorter "MinFirePower" would probably do, without being any more confusing than "MinimalFirePower" (when followed by a value that is *not* the "minimal" firepower but sort of boolean enabling the bonus)
Reply To cazfi
Shorter "MinFirePower" would probably do, without being any more confusing than "MinimalFirePower" (when followed by a value that is *not* the "minimal" firepower but sort of boolean enabling the bonus)
Maybe "LowFirepower" would be less confusing?
Attached patches go for "LowFirepower"
When pushing this, also update S3_1 commit hash that master does CI ruleup tests from.
As we're changing hardcoded firepower of '1' as used by various special cases to a ruleset defined values in #43041, name of combat bonus "FirePower1" is getting misleading. Rename it to "MinimalFirePower".
As part of #43200, this has also been posted to http://forum.freeciv.org/f/viewtopic.php?f=14&t=92036