Incidencia #43204

Drop unused last_turns_shield_surplus from edit_city packet

Abrir Fecha: 2021-11-13 17:16 Última actualización: 2021-11-30 14:15

Informador:
Propietario:
Tipo:
Estado:
Cerrado
Componente:
Prioridad:
5 - Medium
Gravedad:
5 - Medium
Resolución:
Fixed
Fichero:
1

Details

Ihnatus in #42685:
"There is a field last_turns_shield_surplus in editing protocol but it is currently not used."

Drop the unused field from the branches where network protocol change is trivially allowed (S3_1 & master)

Ticket History (3/6 Histories)

2021-11-13 17:16 Updated by: cazfi
  • New Ticket "Drop unused last_turns_shield_surplus from edit_city packet" created
2021-11-13 17:30 Updated by: cazfi
  • Resolución Update from Ninguno to Accepted
2021-11-14 07:42 Updated by: ihnatus
Comentario

Hm, maybe make use of it in newer versions rather than dropping it? Well, it's not a minute task to understand what shields do what and what we want them to do...

2021-11-14 08:26 Updated by: cazfi
Comentario

Reply To ihnatus

Hm, maybe make use of it in newer versions rather than dropping it? Well, it's not a minute task to understand what shields do what and what we want them to do...

I find it unlikely that it will ever get used. For starters, there isn't often such a thing as "last turn" for a city in editor, as the city has likely been added in the same turn.

If that field is ever needed in the network protocol, it's trivial to add back at that time - no need to keep on sending (uninitialized - delta protocol poison) value meanwhile.

2021-11-30 14:15 Updated by: cazfi
  • Estado Update from Open to Cerrado
  • Propietario Update from (Ninguno) to cazfi
  • Resolución Update from Accepted to Fixed

Editar

Please login to add comment to this ticket » Entrar