Incidencia #43870

Client returns with EXIT_SUCCESS after failing to load tileset

Abrir Fecha: 2022-02-15 18:33 Última actualización: 2022-03-03 01:10

Informador:
Propietario:
Tipo:
Estado:
Cerrado
Componente:
Prioridad:
5 - Medium
Gravedad:
5 - Medium
Resolución:
Fixed
Fichero:
3

Details

Client is supposed to return EXIT_FAILURE when it aborts due to failed tileset load:

--

log_error(_("Can't load requested tileset %s!"), forced_tileset_name);
client_exit();
return EXIT_FAILURE;

--

But client_exit() there never returns (should be marked noreturn, but that's another issue) to do that 'return EXIT_FAILURE'. Instead it does 'exit(EXIT_SUCCESS);'

Ticket History (3/9 Histories)

2022-02-15 18:33 Updated by: cazfi
  • New Ticket "Client returns with EXIT_SUCCESS after failing to load tileset" created
2022-02-20 09:26 Updated by: cazfi
  • Propietario Update from (Ninguno) to cazfi
  • Resolución Update from Ninguno to Accepted
  • Hito Update from (Ninguno) to 3.0.1 (cerrado)
2022-02-20 10:07 Updated by: cazfi
Comentario

Going to push also to S2_6 (S3_0 patch applies) as this helps debugging efforts when porting to new environments (and that's what S2_6 is all about now - only used for platforms for which S3_0 is not easy to reach)

2022-02-20 21:14 Updated by: cazfi
Comentario

Reply To cazfi

Going to push also to S2_6 (S3_0 patch applies)

S2_6 will need patch of its own - xaw-client has calls to client_exit() (which is probably the reason the function is not static in client_main.c - something I wondered when making the patch for later branches)

2022-02-20 21:26 Updated by: cazfi
Comentario

Reply To cazfi

S2_6 will need patch of its own

Attached

2022-03-03 01:10 Updated by: cazfi
  • Estado Update from Open to Cerrado
  • Resolución Update from Accepted to Fixed

Editar

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Entrar