city_size_add(): Use 'size' variable

• Informador: cazfi
• Propietario: cazfi
• Tipo: Patches
• Estado: Cerrado
• Componente: General
• Hito: 3.0.1 (cerrado)
• Prioridad: 5 - Medium
• Gravedad: 5 - Medium
• Resolución: Fixed
• Fichero: 1

Details

city_size_add() assigns city size to a variable, but then calls city_size_get() again when it needs it. Use the variable instead. This is a really minor optimization, but more importantly it helps in getting rid compiler warning in NDEBUG build; currently 'size' is a set but unused variable outside fc_assert().

Ticket History (3/4 Histories)

2022-03-04 16:35 Updated by: cazfi

• New Ticket "city_size_add(): Use 'size' variable" created

2022-03-06 05:24 Updated by: cazfi

• File 0043-city_size_add-Use-variable-size-instead-of-recalcula.patch (File ID: 8701) is attached

2022-03-06 05:24 Updated by: cazfi

• Propietario Update from (Ninguno) to cazfi
• Resolución Update from Ninguno to Accepted

2022-03-20 08:30 Updated by: cazfi

• Estado Update from Open to Cerrado
• Resolución Update from Accepted to Fixed