req_text_insert(): Fallthrough from VUT_CITYSTATUS to VUT_MINLATITUDE

• Informador: cazfi
• Propietario: cazfi
• Tipo: Bugs
• Estado: Cerrado
• Componente: General
• Hito: 3.1.0 (cerrado)
• Prioridad: 5 - Medium
• Gravedad: 5 - Medium
• Resolución: Fixed
• Fichero: 2

Details

Compiling master with --enable-debug=checks:

../../../src/common/reqtext.c: In function ‘req_text_insert’:
../../../src/common/reqtext.c:2888:12: error: this statement may fall through (-Werror=implicit-fallthrough=)

2888 | } else {

|

../../../src/common/reqtext.c:2949:3: note: here

2949 | case VUT_MINLATITUDE:

Seems like a genuine bug; unsupported ranges just "break;" from the inner switch, and there's neither break or return after that to prevent falling through in the outer switch.

Ticket History (3/6 Histories)

2022-03-12 22:53 Updated by: cazfi

• New Ticket "req_text_insert(): Fallthrough form VUT_CITYSTATUS to VUT_MINLATITUDE" created

2022-03-12 23:03 Updated by: cazfi

• File 0049-req_text_insert-Fix-fallthrough-from-VUT_CITYSTATUS.patch (File ID: 8743) is attached

2022-03-12 23:03 Updated by: cazfi

• File 0036-req_text_insert-Fix-fallthrough-from-VUT_CITYSTATUS.patch (File ID: 8744) is attached

2022-03-12 23:04 Updated by: cazfi

• Propietario Update from (Ninguno) to cazfi
• Resolución Update from Ninguno to Accepted
• Hito Update from (Ninguno) to 3.1.0 (cerrado)

Comentario

Really a bug in master only, but better to clean up in S3_1 too.

2022-03-14 14:14 Updated by: cazfi

• Summary Updated

2022-03-24 02:30 Updated by: cazfi

• Estado Update from Open to Cerrado
• Resolución Update from Accepted to Fixed