Incidencia #44383

Saving lua objects by rule_name

Abrir Fecha: 2022-04-15 13:10 Última actualización: 2022-04-26 14:47

Informador:
Propietario:
Tipo:
Estado:
Cerrado
Componente:
Prioridad:
5 - Medium
Gravedad:
5 - Medium
Resolución:
Fixed
Fichero:
1

Details

At this point this ticket is mostly a placeholder, but we need to think what to do with saving the lua objects. I don't like the idea of postponing those long-standing issues futher (-> 3.2), so this ticket blocking S3_1-d3f at least prevents us from forgetting about them and going d3f accidentally without resolving the issue.

Ticket History (3/7 Histories)

2022-04-15 13:10 Updated by: cazfi
  • New Ticket "Saving lua objects by rule_name" created
2022-04-15 13:10 Updated by: cazfi
  • Details Updated
2022-04-16 12:46 Updated by: cazfi
Comentario

The question with this is whether we just improve _freeciv_state_dump() a bit in this respect, or should we do the total replacement at this point: http://forum.freeciv.org/f/viewtopic.php?f=14&t=91972#p103950

Quick fix would 1) still be an improvement, and there's no *regression* compared to S3_0. 2) Be the quick solution, to get d3f unblocked.

Yet, I'd hate to postpone the overall fix yet another version.

2022-04-16 13:36 Updated by: cazfi
  • Propietario Update from (Ninguno) to cazfi
  • Resolución Update from Ninguno to Accepted
Comentario

I think that attached patch to _freeciv_data_dump() is already a huge improvement. Going by that if nobody objects.

Something similar would be good to get to S3_0 too, but will probably open a completely new ticket about that rather than trying to implement the port in this ticket. The limitations of the lua API might make the implementation more hairy in that branch.

2022-04-24 01:43 Updated by: cazfi
Comentario

Reply To cazfi

Something similar would be good to get to S3_0 too, but will probably open a completely new ticket about that

-> #44447

2022-04-26 14:47 Updated by: cazfi
  • Estado Update from Open to Cerrado
  • Resolución Update from Accepted to Fixed

Editar

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Entrar