Incidencia #44685

Several unique units given as start units

Abrir Fecha: 2022-05-27 10:41 Última actualización: 2022-06-03 06:47

Informador:
Propietario:
Tipo:
Estado:
Cerrado
Componente:
Prioridad:
5 - Medium
Gravedad:
5 - Medium
Resolución:
Fixed
Fichero:
2

Details

Split from https://www.hostedredmine.com/issues/870631 reported by Alexandro Ignatiev.

Several unique units are given when they are requested by the startunits setting.

"The function that gives these units is crole_to_unit_type() in server/gamehand.c: if it fails grant a buildable unit of the role to the player, it just takes the first ruleset's one resorting to get_role_unit() in common/unittype.c, and that function (used elsewhere, don't change) does not care about uniqueness."

get_role_unit() couldn't care about uniqueness even if it wanted - it has no unit list to check the uniqueness within. As for crole_to_unit_type() users, it seems to me that all of them would want the uniqueness check when they give pplayer, or would not care.

Ticket History (3/5 Histories)

2022-05-27 10:41 Updated by: cazfi
  • New Ticket "Several unique units given as start units" created
2022-05-27 10:51 Updated by: cazfi
  • Resolución Update from Ninguno to Accepted
Comentario

Plan to push even to S2_6

2022-06-03 06:47 Updated by: cazfi
  • Estado Update from Open to Cerrado
  • Resolución Update from Accepted to Fixed

Editar

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Entrar