Incidencia #44870

secfile_lookup_str_default() to report errors

Abrir Fecha: 2022-06-20 01:42 Última actualización: 2023-01-07 02:53

Informador:
Propietario:
(Ninguno)
Tipo:
Estado:
Open
Componente:
Hito:
(Ninguno)
Prioridad:
5 - Medium
Gravedad:
5 - Medium
Resolución:
Ninguno
Fichero:
Ninguno

Details

My comment in https://www.hostedredmine.com/issues/720559 :

--

in principle illegal (though not causing load-time error) "obsolete_by = FALSE" definition plays a role here. 'obsolete_by' is not an boolean option.

--

The reason there's no error catched, is that obsolete_by is read with secfile_lookup_str_default(), that never returns any indication of errors - it just returns the 'default' value in these cases too.

I'd like to change it to return NULL on error (and 'default' only when there's no value given in the file being read), but that might break too many places currently relying on the return value to always be an usable string.

Ticket History (2/2 Histories)

2022-06-20 01:42 Updated by: cazfi
  • New Ticket "secfile_lookup_str_default() to report errors" created
2023-01-07 02:53 Updated by: cazfi
Comentario

Interim improvement -> #46466

Attachment File List

No attachments

Editar

Please login to add comment to this ticket » Entrar