Incidencia #45076

Sort out unknown research targets

Abrir Fecha: 2022-07-10 04:07 Última actualización: 2022-10-11 13:01

Informador:
Propietario:
Tipo:
Estado:
Cerrado
Componente:
Prioridad:
5 - Medium
Gravedad:
5 - Medium
Resolución:
Fixed
Fichero:
3

Details

Spotted during work on #45068. A comment in common/research.h says: "For enemies, A_UNKNOWN is sent to the client". Actually, if you don't have embassy, you don't get research info and in the memory there is the default A_UNSET value. Also, if you lose embassy data (wonder deprecates, teammate with embassy killed) during client session, then the research info gets frozen in the last known state that is possibly not wanted or should look another way.

Ticket History (3/8 Histories)

2022-07-10 04:07 Updated by: ihnatus
  • New Ticket "Sort out unknown research targets" created
2022-07-15 16:44 Updated by: cazfi
Comentario

A good implementation will do changes on network protocol level, don't you think? (Sending full research info packet with dummy values sounds excessive)

Targeting this to block S3_1 npf - doesn't mean we can't make some kind of solution to S3_0 (maybe even with optional network capabilities)

2022-09-28 06:28 Updated by: cazfi
Comentario

If someone is about to look at this, note that I have partly written patch for this, but currently waiting for me to get some other things out of the way. You may want to get that instead of writing everything from scratch.

2022-10-06 10:05 Updated by: cazfi
  • Propietario Update from (Ninguno) to cazfi
  • Resolución Update from Ninguno to Accepted
Comentario

Targeted both to 3.0.5 and S3_1-npf, but we can have only one target listed.

2022-10-11 13:01 Updated by: cazfi
Comentario

Reply To cazfi

Targeted both to 3.0.5 and S3_1-npf, but we can have only one target listed.

Now that it's in (before S3_1-npf), changing documented target to 3.0.5, for the benefit of collecting NEWS for 3.1.0 - will see that this one is NOT a new thing in 3.1.

Editar

Please login to add comment to this ticket » Entrar