Unsigned max_trade_routes() return value

• Informador: cazfi
• Propietario: cazfi
• Tipo: Patches
• Estado: Cerrado
• Componente: General
• Hito: 3.0.4 (cerrado)
• Prioridad: 5 - Medium
• Gravedad: 5 - Medium
• Resolución: Fixed
• Fichero: 1

Details

max_trade_routes() never returns a negative value. Its return type should reflect this.

I think that some clang analyzer warnings we're getting result only from the fact that compiler considers the possibility that a value got from max_trade_routes() is negative.

Ticket History (3/4 Histories)

2022-08-07 00:49 Updated by: cazfi

• New Ticket "Unsigned max_trade_routes() return value" created

2022-08-21 18:08 Updated by: cazfi

• File 0041-Make-max_trade_routes-return-type-unsigned.patch (File ID: 10121) is attached

2022-08-21 18:08 Updated by: cazfi

• Propietario Update from (Ninguno) to cazfi
• Resolución Update from Ninguno to Accepted
• Hito Update from (Ninguno) to 3.0.4 (cerrado)

2022-08-29 18:07 Updated by: cazfi

• Estado Update from Open to Cerrado
• Resolución Update from Accepted to Fixed