Sanity check rule_name uniqueness

• Informador: cazfi
• Propietario: (Ninguno)
• Tipo: Patches
• Estado: Open
• Componente: Server
• Hito: 3.1.1
• Prioridad: 5 - Medium
• Gravedad: 5 - Medium
• Resolución: Ninguno
• Fichero: 1

Details

There's no check against multiple ruleset items (of the same type) having the same rule_name.

Ticket History (3/5 Histories)

2022-08-23 05:02 Updated by: cazfi

• New Ticket "Sanity check rule_name uniqueness" created

2023-02-28 02:05 Updated by: lachu

• File 0001-OSDN-TICKET-45428-S-awomir-Lach-slawek-lach.art.pl.patch (File ID: 11735) is attached

2023-02-28 02:08 Updated by: lachu

Comentario

Reply To cazfi

There's no check against multiple ruleset items (of the same type) having the same rule_name.

0001-OSDN-TICKET-45428-S-awomir-Lach-slawek-lach.art.pl.patch(19KB)

Done. Using SPECHASH.

I did not analyze Freeciv code, but in general programming dictionaries/hashtables are generating numbers for each kind of key, even it is a string. I remember that. So I use spechash with CString as key and CString as value. We store game name as key and ruledit section name as value. When key exist, we print current name (key) with previous section name (value), with the same game name.

EDIT: Remove typo in this comment.

(Edited, 2023-03-06 01:57 Updated by: lachu)

2023-09-06 21:55 Updated by: cazfi

• Hito Update from (Ninguno) to 3.0.10 (cerrado)

2024-02-09 15:42 Updated by: cazfi

• Hito Update from 3.0.10 (cerrado) to 3.1.1