unit_list_iterate_safe() evaluates 'unitlist' twice

• Informador: cazfi
• Propietario: cazfi
• Tipo: Bugs
• Estado: Cerrado
• Componente: General
• Hito: 3.0.4 (cerrado)
• Prioridad: 5 - Medium
• Gravedad: 5 - Medium
• Resolución: Fixed
• Fichero: 1

Details

unit_list_iterate_safe() evaluates 'unitlist' parameter twice (sometimes); once to get its size, and if the size is above zero, second time to iterate it.

Ticket History (3/4 Histories)

2022-08-27 19:08 Updated by: cazfi

• New Ticket "unit_list_iterate_safe() evaluates 'unitlist' twice" created

2022-09-03 13:36 Updated by: cazfi

• File 0053-_iterate_safe-Evaluate-list-parameter-just-once.patch (File ID: 10233) is attached

2022-09-03 13:38 Updated by: cazfi

• Propietario Update from (Ninguno) to cazfi
• Resolución Update from Ninguno to Accepted
• Hito Update from (Ninguno) to 3.0.4 (cerrado)

Comentario

Equivalent behavior with other _iterate_safe() macros. All fixed in the attached patch. Unlikely to make much difference with current users (but I've not evaluated all of those)

2022-09-13 14:13 Updated by: cazfi

• Estado Update from Open to Cerrado
• Resolución Update from Accepted to Fixed