Unit requirements vector freed only when unit has helptext

• Informador: cazfi
• Propietario: cazfi
• Tipo: Bugs
• Estado: Cerrado
• Componente: General
• Hito: 3.1.0 (cerrado)
• Prioridad: 5 - Medium
• Gravedad: 5 - Medium
• Resolución: Fixed
• Fichero: 1

Details

unit_type_free() does requirement_vector_free(&(punittype->build_reqs)); within a "if (NULL != punittype->helptext) {" -block. So the requirement vector is not freed if the unit has no hand-written helptext.

I found this when I were looking if a bug could be explained by some unit requirements from earlier rulesets leaking to a newly loaded one. Not sure if this one could have such an effect.

Ticket History (3/4 Histories)

2022-09-05 06:09 Updated by: cazfi

• New Ticket "Unit requirements vector freed only when unit has helptext" created

2022-09-05 06:16 Updated by: cazfi

• File 0053-Always-free-unit-build-reqs-vector-in-unit_type_free.patch (File ID: 10256) is attached

2022-09-05 06:16 Updated by: cazfi

• Propietario Update from (Ninguno) to cazfi
• Resolución Update from Ninguno to Accepted

2022-09-17 16:43 Updated by: cazfi

• Estado Update from Open to Cerrado
• Resolución Update from Accepted to Fixed