can_player_build_unit_direct() double is_barbarian() call

• Informador: cazfi
• Propietario: cazfi
• Tipo: Bugs
• Estado: Cerrado
• Componente: General
• Hito: 3.2.0
• Prioridad: 5 - Medium
• Gravedad: 5 - Medium
• Resolución: Fixed
• Fichero: 1

Details

can_player_build_unit_direct() does 'barbarian = is_barbarian(p)" assignment twice (in the beginning, and a bit later. It's already needed before the latter one). As it's a function call, compiler even cannot leave one out.

Ticket History (3/4 Histories)

2022-09-10 09:41 Updated by: cazfi

• New Ticket "can_player_build_unit_direct() double is_barbarian() call" created

2022-10-06 07:18 Updated by: cazfi

• File 0032-Drop-extraneous-is_barbarian-call-from-can_player_bu.patch (File ID: 10477) is attached

2022-10-06 07:18 Updated by: cazfi

• Propietario Update from (Ninguno) to cazfi
• Resolución Update from Ninguno to Accepted

2022-10-10 12:23 Updated by: cazfi

• Estado Update from Open to Cerrado
• Resolución Update from Accepted to Fixed