fc_vsnprintf() local buffer not freed

• Informador: cazfi
• Propietario: cazfi
• Tipo: Bugs
• Estado: Cerrado
• Componente: General
• Hito: 3.0.5 (cerrado)
• Prioridad: 5 - Medium
• Gravedad: 5 - Medium
• Resolución: Fixed
• Fichero: 6

Details

Valgrind on S3_1 reports memory leak on get_option_malloc() called from on server for --read option.

Ticket History (3/11 Histories)

2022-10-05 10:30 Updated by: cazfi

• New Ticket "server.script_filename not freed" created

2022-10-05 10:38 Updated by: cazfi

• Hito Update from (Ninguno) to 3.0.5 (cerrado)
• Componente Update from Server to General
• Summary Updated

Comentario

Reply To cazfi

Valgrind on S3_1 reports memory leak on get_option_malloc() called from on server for --read option.

The leak is in fc_vsnprintf() fallback functionality allocating local buffer. The script_filename option gets freed by the garbage collecting feature of the option handling.

2022-10-08 09:14 Updated by: cazfi

• File 0035-Free-internal-fc_vsnprintf-buffer.patch (File ID: 10509) is attached

2022-10-08 09:14 Updated by: cazfi

• File 0028-Free-internal-fc_vsnprintf-buffer.patch (File ID: 10510) is attached

2022-10-08 09:14 Updated by: cazfi

• File 0020-Free-internal-fc_vsnprintf-buffer.patch (File ID: 10511) is attached

2022-10-08 09:14 Updated by: cazfi

• Propietario Update from (Ninguno) to cazfi
• Resolución Update from Ninguno to Accepted

2022-10-08 09:26 Updated by: cazfi

• File 0002-Free-internal-fc_vsnprintf-buffer.patch (File ID: 10512) is attached

2022-10-08 09:26 Updated by: cazfi

• File 0028-Free-internal-fc_vsnprintf-buffer.patch (File ID: 10513) is attached

2022-10-08 09:26 Updated by: cazfi

• File 0020-Free-internal-fc_vsnprintf-buffer.patch (File ID: 10514) is attached

2022-10-08 09:29 Updated by: cazfi

Comentario

- Added S2_6 version. Though this is critical (not real leak, but just missing cleanup on program exit - main bad effect being spamming error logs), further fixes will be easier to backport on top of it
- New S3_1 & S3_0 versions with a fix to a build breaking typo

2022-10-15 05:44 Updated by: cazfi

• Estado Update from Open to Cerrado
• Resolución Update from Accepted to Fixed