savegames: "Unused entry" warnings about traderoute padding

• Informador: cazfi
• Propietario: cazfi
• Tipo: Bugs
• Estado: Cerrado
• Componente: Server
• Hito: 3.0.5 (cerrado)
• Prioridad: 5 - Medium
• Gravedad: 5 - Medium
• Resolución: Fixed
• Fichero: 3

Details

Traderoute padding causes "unused entry" warnings while reading savegames.

Probably should implement #45855 first as the saving side change.

Ticket History (3/6 Histories)

2022-10-14 11:33 Updated by: cazfi

• New Ticket "savegames: "Unused entry" warnings about traderoute padding" created

2022-11-26 13:26 Updated by: cazfi

• File 0034-Savegame-Fix-unused-entry-warnings-about-traderoute-.patch (File ID: 10928) is attached

2022-11-26 13:26 Updated by: cazfi

• File 0029-Savegame-Fix-unused-entry-warnings-about-traderoute-.patch (File ID: 10929) is attached

2022-11-26 13:27 Updated by: cazfi

• File 0020-Savegame-Fix-unused-entry-warnings-about-traderoute-.patch (File ID: 10930) is attached

2022-11-26 13:31 Updated by: cazfi

• Propietario Update from (Ninguno) to cazfi
• Resolución Update from Ninguno to Accepted

Comentario

All branches discard padding from < 3.2 savegames up to MAX_TRADE_ROUTES(_OLD). Master patch also adds better handling of 3.2 savegames: amount of padding is saved to the savegame, and that amount of padding gets discarded. This can be become more important in the future, assuming we increase MAX_TRADE_ROUTES ( #45857 )

2022-11-30 15:02 Updated by: cazfi

• Estado Update from Open to Cerrado
• Resolución Update from Accepted to Fixed