pf_attack_possible() int-conversion warning

• Informador: cazfi
• Propietario: cazfi
• Tipo: Bugs
• Estado: Cerrado
• Componente: General
• Hito: 3.0.6 (cerrado)
• Prioridad: 5 - Medium
• Gravedad: 5 - Medium
• Resolución: Fixed
• Fichero: 2

Details

Testing with gcc-13 in c2x (likely c23) standard mode: S3_1 pf_attack_possible() assignment from is_non_allied_city_tile() to non_allied_city gives error about converting pointer to int.

Ticket History (3/7 Histories)

2022-12-18 08:08 Updated by: cazfi

• New Ticket "pf_attack_possible() int-conversio warning" created

2022-12-18 08:08 Updated by: cazfi

• Summary Updated

2022-12-20 13:11 Updated by: None

Comentario

The problem is that unlike their name suggest is_..._city_tile() functions return a pointer, not a boolean. That has worked under earlier C standard versions.

2022-12-29 11:12 Updated by: cazfi

• File 0031-Make-is_._city_tile-to-return-bool.patch (File ID: 11226) is attached

2022-12-29 11:12 Updated by: cazfi

• File 0017-Make-is_._city_tile-to-return-bool.patch (File ID: 11227) is attached

2022-12-29 11:14 Updated by: cazfi

• Propietario Update from (Ninguno) to cazfi
• Resolución Update from Ninguno to Accepted
• Hito Update from (Ninguno) to 3.0.6 (cerrado)

Comentario

No S2_6 patch yet - have to confirm if one is needed. Review period for later branches running anyway.

2023-01-02 12:32 Updated by: cazfi

• Estado Update from Open to Cerrado
• Resolución Update from Accepted to Fixed