Incidencia #46447

calc_activity() optimizations

Abrir Fecha: 2023-01-04 16:35 Última actualización: 2023-01-17 00:09

Informador:
Propietario:
Tipo:
Estado:
Cerrado
Componente:
Prioridad:
5 - Medium
Gravedad:
5 - Medium
Resolución:
Fixed
Fichero:
1

Details

activity_type_iterate() loop in calc_activity() does tile_activity_time() & stuff "1 + num_extras * 2" times for every activity, when it could be just 1 for activities that are not about extras, and num_extras for activities that are about them.

It also memset() to zero what it had allocated with fc_calloc(), already giving zeroed memory.

Ticket History (3/6 Histories)

2023-01-04 16:35 Updated by: cazfi
  • New Ticket "calc_activity() optimizations" created
2023-01-04 16:35 Updated by: cazfi
  • Details Updated
2023-01-04 16:40 Updated by: cazfi
Comentario

This is required for #46448, and should be implemented so that it gets enabled.

2023-01-10 09:18 Updated by: cazfi
  • Propietario Update from (Ninguno) to cazfi
  • Resolución Update from Ninguno to Accepted
  • Hito Update from (Ninguno) to 3.1.0-beta1 (cerrado)
Comentario

Not targeting to S3_0, as Irrigate and Mine having both targeted and targetless forms there might not work well together with this change, and usually client-side performance issues are not that critical.

2023-01-17 00:09 Updated by: cazfi
  • Estado Update from Open to Cerrado
  • Resolución Update from Accepted to Fixed

Editar

Please login to add comment to this ticket » Entrar