sdl2: popup_government_dialog() NULL dereference when player cannot change to any government

• Informador: cazfi
• Propietario: cazfi
• Tipo: Bugs
• Estado: Cerrado
• Componente: SDL2-client
• Hito: 3.0.6 (cerrado)
• Prioridad: 5 - Medium
• Gravedad: 5 - Medium
• Resolución: Fixed
• Fichero: 3

Details

S3_0 sdl2-client popup_government_dialog():

--

while (pGov_Button != pGov_Dlg->pEndWidgetList) {
pGov_Button->size.w = max_w;

--

pGov_Button is NULL if not populated by the iteration that goes through governments that player can change to. pEndWidgetList is still not-NULL.

Ticket History (3/7 Histories)

2023-01-04 20:19 Updated by: cazfi

• New Ticket "sdl2: popup_government_dialog() NULL dereference when player cannot change to any government" created

2023-01-06 14:27 Updated by: cazfi

• File 0035-sdl2-Fix-crash-when-there-s-no-government-to-switch-.patch (File ID: 11314) is attached

2023-01-06 14:27 Updated by: cazfi

• File 0014-sdl2-Fix-crash-when-there-s-no-government-to-switch-.patch (File ID: 11315) is attached

2023-01-06 14:27 Updated by: cazfi

• File 0007-sdl-2-Fix-crash-when-there-s-no-government-to-switch.patch (File ID: 11316) is attached

2023-01-06 14:28 Updated by: cazfi

Comentario

master version applies to S3_1 too.
S2_6 version has the fix also for sdl-client

2023-01-06 14:28 Updated by: cazfi

• Propietario Update from (Ninguno) to cazfi
• Resolución Update from Ninguno to Accepted

2023-01-12 11:22 Updated by: cazfi

• Estado Update from Open to Cerrado
• Resolución Update from Accepted to Fixed