Removed player may left as the original founder of a city

• Informador: cazfi
• Propietario: cazfi
• Tipo: Bugs
• Estado: Cerrado
• Componente: General
• Hito: 3.0.6 (cerrado)
• Prioridad: 5 - Medium
• Gravedad: 5 - Medium
• Resolución: Fixed
• Fichero: 1

Details

Found when testing #46402. While the crash encountered is in the new code of that ticket, I think the root cause can cause problems with other parts of the code too.

When a player is removed from the game, they are left as the "original" founder of any cities they have founded, leading to illegal access of the removed player via that pointer.

Ticket History (3/7 Histories)

2023-01-10 14:12 Updated by: cazfi

• New Ticket "Removed player may left as the original founder of a city" created

2023-01-11 01:57 Updated by: cazfi

• File 0034-Send-city-original-owner-information-to-client.patch (File ID: 11357) is attached

2023-01-11 01:57 Updated by: cazfi

• Propietario Update from (Ninguno) to cazfi
• Resolución Update from Ninguno to Accepted

Comentario

For all branches, including S2_6.

2023-01-15 07:12 Updated by: cazfi

• File 0033-Update-founder-information-of-cities-when-a-player-r.patch (File ID: 11377) is attached

2023-01-15 07:12 Updated by: cazfi

• File 0034-Send-city-original-owner-information-to-client.patch (File ID: 11357) is deleted

2023-01-15 07:13 Updated by: cazfi

Comentario

Attached correct patch.

2023-01-17 23:19 Updated by: cazfi

• Estado Update from Open to Cerrado
• Resolución Update from Accepted to Fixed