Infinite recursion: found_new_tech() -> choose_tech() -> tech_researched() -> repeat

• Informador: cazfi
• Propietario: cazfi
• Tipo: Bugs
• Estado: Cerrado
• Componente: General
• Hito: 3.0.7 (cerrado)
• Prioridad: 5 - Medium
• Gravedad: 5 - Medium
• Resolución: Fixed
• Fichero: 1

Details

Backtrace of a crashed S3_0 autogame reveals recursive loop of found_new_tech() -> choose_tech() -> tech_researched() -> from the beginning

choose_tech() seems to have 201 (which is A_FUTURE, I think) as a parameter.

Ticket History (3/7 Histories)

2023-01-19 01:05 Updated by: cazfi

• New Ticket "Infinite recursion: found_new_tech() -> choose_tech() -> tech_researched() -> repeat" created

2023-01-19 02:35 Updated by: cazfi

Comentario

This was caused by a local (-> not yet in repo) patch #45115.

A_FUTURE is a tech has it's requirements set to A_NEVER, yet it's supposed to be in game.

2023-01-19 06:43 Updated by: cazfi

• Hito Update from 3.0.6 (cerrado) to 3.0.7 (cerrado)
• Componente Update from Server to General

Comentario

Reply To cazfi

This was caused by a local (-> not yet in repo) patch #45115.

It's possible that A_FUTURE not being considered valid advance causes some other issues, but those would have been there for a long time, not to be a recent regression. As changing it has significant risk of breaking some caller, let's leave this to the next full cycle.

2023-02-14 13:38 Updated by: cazfi

• File 0042-valid_advance-Consider-Future-techs-valid-ones.patch (File ID: 11633) is attached

2023-02-14 13:38 Updated by: cazfi

• Propietario Update from (Ninguno) to cazfi
• Resolución Update from Ninguno to Accepted

2023-02-17 13:38 Updated by: cazfi

• Estado Update from Open to Cerrado
• Resolución Update from Accepted to Fixed

2023-03-20 03:31 Updated by: cazfi

Comentario

Reply To cazfi

As changing it has significant risk of breaking some caller, let's leave this to the next full cycle.

We now have such a breakage in #47574