win32 crash on unit_activity_text()

• Informador: cazfi
• Propietario: cazfi
• Tipo: Bugs
• Estado: Cerrado
• Componente: General
• Hito: 3.0.6 (cerrado)
• Prioridad: 5 - Medium
• Gravedad: 5 - Medium
• Resolución: Fixed
• Fichero: 4

Details

win32 gtk3.22-client crashes when entering game. Seen on S3_1 and master (where we don't support win32 as such, but underlying bug might be just dormant on other environments).

Debugger reveals that the crash happens on unit_activity_text() call of astr_clear().

unit_activity_text() header has "FIXME: Convert all callers of this function to unit_activity_astr() because this function is not re-entrant." - it's quite possible that this lack of being re-entrant is the cause of this crash.

Ticket History (3/7 Histories)

2023-01-21 11:34 Updated by: cazfi

• New Ticket "win32 crash on unit_activity_text()" created

2023-01-21 12:44 Updated by: cazfi

• File 0033-Retire-unit_activity_text.patch (File ID: 11423) is attached

2023-01-21 12:45 Updated by: cazfi

• File 0016-Retire-unit_activity_text.patch (File ID: 11424) is attached

2023-01-21 12:45 Updated by: cazfi

• File 0012-Retire-unit_activity_text.patch (File ID: 11425) is attached

2023-01-21 12:45 Updated by: cazfi

• File 0002-Retire-unit_activity_text.patch (File ID: 11426) is attached

2023-01-21 12:46 Updated by: cazfi

• Propietario Update from (Ninguno) to cazfi
• Resolución Update from Ninguno to Accepted
• Hito Update from (Ninguno) to 3.0.6 (cerrado)

Comentario

Reply To cazfi

it's quite possible that this lack of being re-entrant is the cause of this crash.

Yes, getting rid of the unit_activity_text() was the solution. Patches attached for all branches, including S2_6.

2023-01-24 08:43 Updated by: cazfi

• Estado Update from Open to Cerrado
• Resolución Update from Accepted to Fixed