gtk3.22 client runtime error with clang

• Informador: alain_bkr
• Propietario: cazfi
• Tipo: Bugs
• Estado: Cerrado
• Componente: General
• Hito: 3.0.7 (cerrado)
• Prioridad: 5 - Medium
• Gravedad: 5 - Medium
• Resolución: Fixed
• Fichero: 1

Details

3.0.6+ compiled with clang -fsanitize=undefined

client gtk-3.22

../../client/options.c:4527:20: runtime error: applying zero offset to null pointer

../../common/research.c:775:12: runtime error: index 201 out of bounds for type 'const struct research_invention[200]'

../../client/mapview_common.c:214:13: runtime error: -nan is outside the range of representable values of type 'int'
../../client/mapview_common.c:215:13: runtime error: -nan is outside the range of representable values of type 'int'

Ticket History (3/8 Histories)

2023-03-14 09:43 Updated by: alain_bkr

• New Ticket "gtk3.22 client runtime error with clang" created

2023-03-19 22:53 Updated by: cazfi

Comentario

Reply To alain_bkr

../../common/research.c:775:12: runtime error: index 201 out of bounds for type 'const struct research_invention200'

Regression with #46544, I think

2023-03-19 22:53 Updated by: cazfi

• Hito Update from (Ninguno) to 3.0.7 (cerrado)
• Componente Update from (Ninguno) to General

2023-03-20 03:41 Updated by: cazfi

• File 0013-Make-research-invention-array-big-enough-for-A_FUTUR.patch (File ID: 11889) is attached

2023-03-20 03:43 Updated by: cazfi

• Propietario Update from (Ninguno) to cazfi
• Resolución Update from Ninguno to Accepted

Comentario

Bit of an emergency fix attached. It avoids the "out of bounds" error, but I'm not sure what other consequences there is to the fact that A_FUTURE gets treated this way as part of the research structure.

2023-03-23 21:33 Updated by: cazfi

Comentario

Reply To alain_bkr

../../client/options.c:4527:20: runtime error: applying zero offset to null pointer

-> #47663

2023-03-25 01:12 Updated by: cazfi

Comentario

Reply To alain_bkr

../../client/mapview_common.c:214:13: runtime error: -nan is outside the range of representable values of type 'int'
../../client/mapview_common.c:215:13: runtime error: -nan is outside the range of representable values of type 'int'

-> #47679

2023-03-25 01:15 Updated by: cazfi

• Estado Update from Open to Cerrado
• Resolución Update from Accepted to Fixed