city_total_unit_gold_upkeep() : Duplicate unit_list_size() check

• Informador: cazfi
• Propietario: cazfi
• Tipo: Patches
• Estado: Cerrado
• Componente: General
• Hito: 3.1.0-beta4 (cerrado)
• Prioridad: 5 - Medium
• Gravedad: 5 - Medium
• Resolución: Fixed
• Fichero: 1

Details

city_total_unit_gold_upkeep() checks if unit_list_size() is at least one, before iterating the list. That's redundant check, as iteration over zero item list would do nothing. Simplify the code by removing the check.

Ticket History (3/5 Histories)

2023-07-22 03:25 Updated by: cazfi

• New Ticket "city_total_unit_gold_upkeep() : Duplicate unit_list_size() check" created

2023-08-30 11:17 Updated by: cazfi

• Hito Update from (Ninguno) to 3.1.0-beta4 (cerrado)

2023-10-10 07:02 Updated by: cazfi

• File 0035-Simplify-city_total_unit_gold_upkeep.patch (File ID: 13506) is attached

2023-10-10 07:02 Updated by: cazfi

• Propietario Update from (Ninguno) to cazfi
• Resolución Update from Ninguno to Accepted

2023-10-16 00:38 Updated by: cazfi

• Estado Update from Open to Cerrado
• Resolución Update from Accepted to Fixed