gcc-14: city_from_wonder() out-of-bounds array subscript

• Informador: cazfi
• Propietario: cazfi
• Tipo: Bugs
• Estado: Cerrado
• Componente: General
• Hito: 3.0.9 (cerrado)
• Prioridad: 5 - Medium
• Gravedad: 5 - Medium
• Resolución: Fixed
• Fichero: 1

Details

gcc-14 development version, S3_1:

../../../src/common/improvement.c: In function 'city_from_wonder':
../../../src/common/improvement.c:874:33: error: array subscript -1 is below array bounds of 'const int[200]' [-Werror=array-bounds=]
  874 |   int city_id = pplayer->wonders[improvement_index(pimprove)];
      |                 ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../../../src/common/game.h:35,
                 from ../../../src/common/improvement.c:27:
../../../src/common/player.h:301:7: note: while referencing 'wonders'
  301 |   int wonders[B_LAST];              /* contains city id's, WONDER_NOT_BUILT,

Ticket History (3/4 Histories)

2023-10-16 03:50 Updated by: cazfi

• New Ticket "gcc-14: city_from_wonder() out-of-bounds array subscript" created

2023-10-16 03:56 Updated by: cazfi

• File 0031-city_from_wonder-Fix-illegal-array-subscript-warning.patch (File ID: 13541) is attached

2023-10-16 03:59 Updated by: cazfi

• Propietario Update from (Ninguno) to cazfi
• Resolución Update from Ninguno to Accepted
• Hito Update from (Ninguno) to 3.0.9 (cerrado)

Comentario

Patch for all branches, including S2_6, attached.

2023-10-18 00:33 Updated by: cazfi

• Estado Update from Open to Cerrado
• Resolución Update from Accepted to Fixed