#41121: Make counter_type a specenum
Open Date: 2021-01-08 06:39
Last Update: 2022-04-23 18:17
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/41121
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=41121
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-04-23 18:17 Updated by: lachu
Comment:
Reply To cazfi
Reply To lachu
2. Initialize function restored
The way you change its indentation seems wrong. (Do you read your patches - or more easily; 'git diff' output - to see what you are going to submit?)
It was corrected/repaired/fixed.
(about counter_target)
I load it from ruleset
I'm not sure if that will make sense in the future, but at least currently the target is a function of the behavior ("how many turns *city* has been owned" can't be anything but city targeted). So there's no point in exposing it to the ruleset format as if ruleset author could somehow decide what the value is - instead you are forcing him/her to set the value you already know to be the only possible one.
Normal enum restored in one case. Only counter_behavior is as specenum.
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: (None)
Type: Patches
Status: Open
Priority: 5 - Medium
MileStone: 3.2.0
Component: General
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
Make counter_type a specenum to ease support of human readable names for its values.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/41121
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=41121