#44778: Resolve script dangers around unit_change_owner()
Open Date: 2022-06-08 09:48
Last Update: 2022-06-16 07:26
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/44778
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44778
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-06-16 07:26 Updated by: cazfi
Comment:
Reply To ihnatus
Fixed. Also, added a notice on stdout (not shown to the players) if the gold is underflown.
Clarification: This is freeciv logging (like it should), and not necessarily stdout.
---------------------------------------------------------------------
Ticket Status:
Reporter: ihnatus
Owner: cazfi
Type: Bugs
Status: Open [Owner assigned]
Priority: 5 - Medium
MileStone: 3.0.3
Component: Server
Severity: 5 - Medium
Resolution: Accepted
---------------------------------------------------------------------
Ticket details:
A split of #44738.
It should be handled that this function sometimes does not give out a unit due to the callback in wipe_init(). In do_capture_units() stack iteration must be safe. Also, in diplomat_bribe() we should avoid getting into negative gold (what's the alternative?..)
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/44778
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44778