#44892: sdl2: SDL_GetColorKey() assumed to succes Open Date: 2022-06-21 12:54 Last Update: 2022-06-21 20:05 URL for this Ticket: https://osdn.net//projects/freeciv/ticket/44892 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44892 --------------------------------------------------------------------- Last Changes/Comment on this Ticket: 2022-06-21 20:05 Updated by: cazfi * Owner Update from (None) to cazfi * Resolution Update from None to Accepted Comment: Going to push S3_0 patch to S2_6 too --------------------------------------------------------------------- Ticket Status: Reporter: cazfi Owner: cazfi Type: Bugs Status: Open [Owner assigned] Priority: 5 - Medium MileStone: 3.0.3 Component: SDL2-client Severity: 5 - Medium Resolution: Accepted --------------------------------------------------------------------- Ticket details: sdl2-client get_smaller_surface_rect() calls SDL_GetColorKey(), assumes it success, and goes on using the key. The problem is, we don't set the key for most surfaces, and often that call actually fails. -- Ticket information of Freeciv project Freeciv Project is hosted on OSDN Project URL: https://osdn.net/projects/freeciv/ OSDN: https://osdn.net URL for this Ticket: https://osdn.net/projects/freeciv/ticket/44892 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44892