#41121: Make counter_type a specenum Open Date: 2021-01-08 06:39 Last Update: 2022-05-05 23:03 URL for this Ticket: https://osdn.net//projects/freeciv/ticket/41121 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=41121 --------------------------------------------------------------------- Last Changes/Comment on this Ticket: 2022-05-05 23:03 Updated by: lachu Comment: Reply To cazfi Repaired. I also removed comments created by copy operation, which I missed. Reply To cazfi I don't see that change. The latest version still sets MAX_COUNTERS to 20. Did you send wrong file? Sorry, but I thought changing first value of enum to 1 instead of 0 repair the problem. Now, when C initializes int variable with default value (0), it do not collide with 1. I don't really get what you mean by that? The problem I'm talking is that you change MAX_COUNTERS telling how many counters are supported, from COUNTER_COUNT (1) to 20, while we still support just 1 counter (of each type -> COUNTER_COUNT) Hi. Did you miss this message: 2022-04-30 17:38 Updated by: lachu ? I post patch adjusted to your suggestions. --------------------------------------------------------------------- Ticket Status: Reporter: cazfi Owner: cazfi Type: Patches Status: Closed Priority: 5 - Medium MileStone: 3.2.0 Component: General Severity: 5 - Medium Resolution: Fixed --------------------------------------------------------------------- Ticket details: Make counter_type a specenum to ease support of human readable names for its values. -- Ticket information of Freeciv project Freeciv Project is hosted on OSDN Project URL: https://osdn.net/projects/freeciv/ OSDN: https://osdn.net URL for this Ticket: https://osdn.net/projects/freeciv/ticket/41121 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=41121