[Freeciv-tickets] [freeciv] #45872: S3_0 luasql clang analyzer warnings

Back to archive index
OSDN Ticket System norep****@osdn*****
Wed Oct 26 03:25:01 JST 2022


#45872: S3_0 luasql clang analyzer warnings

  Open Date: 2022-10-15 13:24
Last Update: 2022-10-25 21:25

URL for this Ticket:
    https://osdn.net//projects/freeciv/ticket/45872
RSS feed for this Ticket:
    https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45872

---------------------------------------------------------------------

Last Changes/Comment on this Ticket:
2022-10-25 21:25 Updated by: cazfi
 * Owner Update from (None) to cazfi
 * Resolution Update from None to Accepted

Comment:

Patch meant for S3_0 only (not to later branches)

---------------------------------------------------------------------
Ticket Status:

      Reporter: cazfi
         Owner: cazfi
          Type: Bugs
        Status: Open [Owner assigned]
      Priority: 5 - Medium
     MileStone: 3.0.5
     Component: General
      Severity: 5 - Medium
    Resolution: Accepted
---------------------------------------------------------------------

Ticket details:

Clang analyzer gives some NULL dereference warnings about luasql code in S3_0. That does not happen with later branches. I don't know what makes the difference - we have newer version of luasql in S3_1 & master, but the changes don't seem relevant.
It's easy enough to silence those warnings by checking against NULL pointer in the very spots the warnings are given about, but if there's real problem (i.e. if NULL pointers can really make it there) that would only mean that the crash would happen a bit later where the very same pointer would be dereferenced again, even though analyzers heuristics don't catch that.

-- 
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN

Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net

URL for this Ticket:
    https://osdn.net/projects/freeciv/ticket/45872
RSS feed for this Ticket:
    https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45872



More information about the Freeciv-tickets mailing list
Back to archive index