#44959: Savegame:Use saved diplstate order
Open Date: 2022-06-27 03:55
Last Update: 2022-09-07 19:00
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/44959
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44959
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-09-07 19:00 Updated by: cazfi
* Milestone Update from 3.2.0 to S3_2 d3f
Comment:
Reply To cazfi
Diplstate order actually IS loaded in savegame2.c case. For some reason that has not made it to savegame3.c
The thing seems to be that savegame3.c does not save values as integers, but by name. So there's no need to have the order (mapping from integers to names) in the savegame.
So, this ticket turns to one to stop saving the useless information on savegame3.c.
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: (None)
Type: Patches
Status: Open
Priority: 5 - Medium
MileStone: S3_2 d3f
Component: Server
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
Diplstate order is being saved to the savegame, but it's not used in the loading side.
Presumably the reason for that the saving side has been implemented in earlier versions already is for the benefit of newer versions loading such savegames - no need to keep the order present in "historical" versions listed in the newer version binary.
We should implement the loading side too. Targeting initially to master only, but should also confirm that S3_1 still has the same hardcoded order as the earlier versions (so it's ok to keep using that hardcoded order)
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/44959
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44959