#48028: Drop internal "NoVeteran" unit type flag
Open Date: 2023-05-12 06:43
Last Update: 2023-06-09 19:19
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/48028
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=48028
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2023-06-09 19:19 Updated by: cazfi
* Resolution Update from Remind to Accepted
Comment:
Reply To cazfi
Reply To cazfi
Putting on hold for now, as Ihnatus suggests basing NoVeteran functionality *more* on effects (and dropping "Gain Veterancy" action enabler): https://forum.freeciv.org/f/viewtopic.php?t=93908
While that suggestion is not against the core idea of this ticket, current implementation is likely counter-productive in relation to that suggestion (removing "NoVeteran" requirements from many effects in supplied rulesets)
As we already have "Gain Veterancy" as an internal action, testing without this patch produces warnings about extraneous flags. I think this should now go in, to reach some stable point. We can revert everything at once, if we later so decide.
Patch rebased, on top of #48027
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: cazfi
Type: Patches
Status: Open [Owner assigned]
Priority: 5 - Medium
MileStone: S3_3 d3f
Component: General
Severity: 5 - Medium
Resolution: Accepted
---------------------------------------------------------------------
Ticket details:
After #48000 removes last hardcoded use of "NoVeteran" flag, entire flag can be dropped. Rulesets that need it, should implement it as a user unit type flag.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/48028
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=48028