#48293: Narrower data type for diplstate has_reason_to_cancel Open Date: 2023-06-26 01:20 Last Update: 2023-06-26 01:55 URL for this Ticket: https://osdn.net//projects/freeciv/ticket/48293 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=48293 --------------------------------------------------------------------- Last Changes/Comment on this Ticket: 2023-06-26 01:55 Updated by: cazfi * Owner Update from (None) to cazfi * Resolution Update from None to Accepted --------------------------------------------------------------------- Ticket Status: Reporter: cazfi Owner: cazfi Type: Patches Status: Open [Owner assigned] Priority: 5 - Medium MileStone: 3.1.0-beta3 Component: General Severity: 5 - Medium Resolution: Accepted --------------------------------------------------------------------- Ticket details: diplstate has_reason_to_cancel ever takes only values 0, 1, or 2. Yet it uses width of an entire int. Size diplstate of diplstate structure is critical one with high number of players, as the number of structures in memory grow exponentially. -- Ticket information of Freeciv project Freeciv Project is hosted on OSDN Project URL: https://osdn.net/projects/freeciv/ OSDN: https://osdn.net URL for this Ticket: https://osdn.net/projects/freeciv/ticket/48293 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=48293