Incidencia #41911

nuke_pop_loss_pct should round to nearest

Abrir Fecha: 2021-04-03 17:45 Última actualización: 2021-04-10 15:41

Informador:
Propietario:
Tipo:
Estado:
Cerrado
Componente:
Prioridad:
5 - Medium
Gravedad:
5 - Medium
Resolución:
Fixed
Fichero:
1

Details

nuke_pop_loss_pct uses integer math, so it always rounds down. I think it should round to nearest, so for example pct of 25% would still end up reducing size of a city with old size of 3.

However, we should keep the compatibility with 3.0 and earlier that by default city of size 1 is not destroyed. That should not be too hard, as nuke_pop_loss_pct is a new setting in S3_1, i.e., there is no need to support values set for it already in 3.0. Maybe we simply make the default pop_loss_pct 49%.

Ticket History (3/4 Histories)

2021-04-03 17:45 Updated by: cazfi
  • New Ticket "nuke_pop_loss_pct should round to nearest" created
2021-04-03 19:40 Updated by: cazfi
  • Resolución Update from Ninguno to Accepted
2021-04-10 15:41 Updated by: cazfi
  • Estado Update from Open to Cerrado
  • Propietario Update from (Ninguno) to cazfi
  • Resolución Update from Accepted to Fixed

Editar

Please login to add comment to this ticket » Entrar