Incidencia #42989

Default range for "Good" req should be a possible one

Abrir Fecha: 2021-10-07 04:43 Última actualización: 2021-10-30 21:18

Informador:
Propietario:
Tipo:
Estado:
Cerrado
Componente:
Prioridad:
5 - Medium
Gravedad:
5 - Medium
Resolución:
Fixed
Fichero:
2

Details

Brief code analysis of common/requirements.c shows a problem in req_from_str() function. We usually don't actually use default ranges, but if we have them, let them be possible. VUT_GOOD can not have local range, default one should be RANGE_CITY.

Ticket History (3/7 Histories)

2021-10-07 04:43 Updated by: ihnatus
  • New Ticket "Default range for "Good" req should be a possible one" created
2021-10-08 02:20 Updated by: cazfi
Comentario

Less than 36h to beta3 release, it's not even theoretically possible that a fix would get submitted and pass review period before it (in practice we've not pushed anything in since Monday)

2021-10-13 21:27 Updated by: cazfi
Comentario

We define default ranges there, but apparently it's not possible for a ruleset author to rely on it. When one leaves range out from a requirement list:

1: In secfile_lookup_str() [../../../src/utility/registry_ini.c:2177]: secfile '../../src/data/civ2civ3/effects.ruleset' in section 'NULL': "effect_tile_bonus_good.reqs0.range" entry doesn't exist.

2021-10-14 07:27 Updated by: cazfi
  • Resolución Update from Ninguno to Accepted
2021-10-30 21:18 Updated by: cazfi
  • Estado Update from Open to Cerrado
  • Propietario Update from (Ninguno) to cazfi
  • Resolución Update from Accepted to Fixed

Editar

Please login to add comment to this ticket » Entrar