Incidencia #44406

Qt: Shortcuts num_shortcuts wrong

Abrir Fecha: 2022-04-17 21:30 Última actualización: 2022-05-04 12:39

Informador:
Propietario:
Tipo:
Estado:
Cerrado
Componente:
Prioridad:
5 - Medium
Gravedad:
5 - Medium
Resolución:
Fixed
Fichero:
1

Details

Qt-client shortcuts.cpp has a "static int num_shortcuts = 57;" which is used at least to tell number of shortcuts to save and load. The value currently isn't same as highest value in 'enum shortcut_id' (nor +1 for considering the value 0) - I'm not yet entirely sure if it should. But I'm sure that it should have been increased when the new shortcut (for toggling Unit Stack Size) was last added, and it was not. So it's certainly wrong, have to just determine how much.

Ticket History (3/5 Histories)

2022-04-17 21:30 Updated by: cazfi
  • New Ticket "Qt: Shortcuts num_shortcuts wrong" created
2022-04-17 23:47 Updated by: cazfi
Comentario

Fix for #44407 should go in before this - once we save those shortcuts in the end of the array, we don't want to save (so that they may remain in use forever) a wrong one.

2022-04-23 16:40 Updated by: cazfi
  • Propietario Update from (Ninguno) to cazfi
  • Resolución Update from Ninguno to Accepted
  • Hito Update from (Ninguno) to 3.1.0 (cerrado)
2022-05-04 12:39 Updated by: cazfi
  • Estado Update from Open to Cerrado
  • Resolución Update from Accepted to Fixed

Editar

Please login to add comment to this ticket » Entrar