sdl2: city_map_canvas not freed on client exit

• Informador: cazfi
• Propietario: cazfi
• Tipo: Bugs
• Estado: Cerrado
• Componente: SDL2-client
• Hito: 3.0.3 (cerrado)
• Prioridad: 5 - Medium
• Gravedad: 5 - Medium
• Resolución: Fixed
• Fichero: 3

Details

sdl2-client does not free city_map_canvas on exit. Should be fixed just so that it won't show up in valgrind reports any more (possibly causing people to investigate the situation over and over)

Ticket History (3/6 Histories)

2022-06-05 06:26 Updated by: cazfi

• New Ticket "sdl2: city_map_canvas not freed on client exit" created

2022-06-12 04:16 Updated by: cazfi

• File 0039-sdl2-Free-city_map_canvas-on-exit.patch (File ID: 9463) is attached

2022-06-12 04:16 Updated by: cazfi

• File 0018-sdl2-Free-city_map_canvas-on-exit.patch (File ID: 9464) is attached

2022-06-12 04:16 Updated by: cazfi

• File 0009-sdl-2-Free-city_map_canvas-on-exit.patch (File ID: 9465) is attached

2022-06-12 04:19 Updated by: cazfi

• Propietario Update from (Ninguno) to cazfi
• Resolución Update from Ninguno to Accepted

Comentario

Reply To cazfi

Should be fixed just so that it won't show up in valgrind reports any more

These fixes actually handle also such an issue that the city_map_canvas pointer was not initialized, and if it happened to be non-NULL it was assumed to contain a valid value to free() before reallocation. To fix that more serious aspect made also S2_6 version.

2022-06-18 04:56 Updated by: cazfi

• Estado Update from Open to Cerrado
• Resolución Update from Accepted to Fixed